Add tridentImageRegistry to Helm chart (trident-image-registry to cli) #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayrstefan
changed the title
Separate tridentImageRegistry (NetApp images) from imageRegistry (csi sidecar images) in helm chart. Fall back to imageRegistry if tridentImageRegistry is not set. Added --trident-image-registry to installer.
|
This is needed. We strictly use custom registries to avoid rate limits from Docker Hub. We want to pull the Astra/Trident images through that custom registry, but let the CSI Sidecar get pulled from GCR. This currently requires us to hard-specify image versions with the helm chart instead of just specifying a registry for the Trident images. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
The helm chart has a parameter imageRegistry which is used to set an alternative registry url for trident and csi sidecar images which can cause an issue for some installations. That registry has to contain images from two different sources.
This change keeps imageRegistry for the csi sidecar images and adds tridentImageRegistry to use for mirrored trident images.
It tries to do the same for the cli with an addition trident-image-registry parameter
Project tracking
Should fix #772
Do any added TODOs have an issue in the backlog?
N/A
Did you add unit tests? Why not?
I did not find tests for imageRegistry that I could have modified and extended. But I guess it would be good to have test coverage for both parameters.
Does this code need functional testing?
Yes, because I'm no programmer and I don't know if I broke something I did not intend to.
Is a code review walkthrough needed? why or why not?
Don't know.
Should additional test coverage be executed in addition to pre-merge?
Don't know.
Does this code need a note in the changelog?
Changelog entry is included in this PR.
Does this code require documentation changes?
Yes. Both parameters need some documentation.
There is also a breaking change: imageRegistry is not used for trident images any moreAdditional Information
None